Clean up string constraint generator class #4995
Conversation
romainbrenguier
requested review from
martin-cs and
peterschrammel
as code owners
This is not used by method of the class and doesn't belong here.
romainbrenguier
force-pushed
the
clean-up/string-constraint-generator
branch
from
e26991b to
1585bdf
Compare
The constraints should be a return value of the generator methods rather than a field.
romainbrenguier
force-pushed
the
clean-up/string-constraint-generator
branch
2 times, most recently
from
a45bc9a to
8cf5b7a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4995 +/- ##
===========================================
- Coverage 69.44% 69.44% -0.01%
===========================================
Files 1310 1310
Lines 108760 108761 +1
===========================================
Hits 75528 75528
- Misses 33232 33233 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 8cf5b7a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/122697509
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
Not useful anymore.
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 3cc0c72).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/122783561
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
The message field was unused, and the
constraintsfield does not belong here since it is rather the return value of constraint generation than a field.This was triggered by this discussion #4957 (comment)